This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Add derives and borrowed paramaters #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact is_normalized() and From<$projective>: $affine cover the is_zero() special case because they handle the is_zero() special case themselves. I kept the is_zero() special case here for robustness against future modifications, but you may wish to remove it.
burdges
changed the title
|
thanks, I think it makes sense to move things into master. Will review later today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in filecoin-project/research#53, rebase of https://github.com/burdges/pairing/tree/derives_borrows_etc0 but not sure if you want these in a separate branch or not.